[GitHub] [incubator-superset] mahendra commented on issue #5294: [SIP-3] Scheduled email reports for Slices / Dashboards

Wed, 12 Sep 2018 23:27:25 -0700 

@villebro thank you for the detailed review and apologies for the delay in 
responding. Was held up at work.

* Test email feature is implemented. While adding / editing, you are now 
provided an option to send a test email and also a list of recipients.
![image](https://user-images.githubusercontent.com/115988/45470052-f4282000-b6e0-11e8-95a5-c9c9c2933a74.png)

* Lack of transparency about schedule update. I have added it in two places.
  * The help text
![image](https://user-images.githubusercontent.com/115988/45470429-9a285a00-b6e2-11e8-8dfd-21646d18a94d.png)
  * A `flash` message
![image](https://user-images.githubusercontent.com/115988/45470447-a6acb280-b6e2-11e8-95f2-909f40d0168d.png)


[ Full content available at: 
https://github.com/apache/incubator-superset/pull/5294 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to