@aai95 `trunk` branch was broken recently -- can you please rebase this PR to 
pick up latest `trunk` that is fixed now? Otherwise, we can't get a green 
build. Thx.

For testing, we could add a test, but if Consumer/Producer would change the 
bounds, our test would not catch this anyway. Adding those parameters is 
basically code duplication.

If we want to improve the code, Consumer/Producer (or mabye `CommonConfig`) 
should define a `public final static` variable, that define the lower bound, 
and we could use this in all three classes. This way, if the bounds change, all 
are updated and we don't miss anything.

Thoughts?

[ Full content available at: https://github.com/apache/kafka/pull/5643 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

Reply via email to