@leventov thanks for the info! @QiuMM I think we can go ahead and make this non-optional now.
>From the links @leventov provided the original motivation for making it >optional was that other projects that used `server-metrics` had to include the >Sigar repo otherwise. The `server-metrics` code is now embedded in Druid's own `java-util` module now though, and that's not positioned as a general use library for other projects, so I think that concern is less relevant now. Sigar is Apache licensed too, so that's good: https://github.com/hyperic/sigar/blob/master/LICENSE [ Full content available at: https://github.com/apache/incubator-druid/pull/6300 ] This message was relayed via gitbox.apache.org for [email protected]
