The `null` check should be added to check if the user-specified argument is null (the `newLateness`). Not if the class field `allowedLateness` is null. `allowedLateness` can be null, as this is the default value. This check does not break anything and they should be there to tell that if you call the method, you cannot pass a `null` as an argument.
Nobody said to put checks for the `evictor` and the `trigger`. In addition, you should add some tests in the PR. This is not only to test if everything works, but also to guarantee that nobody in the future will break this functionality. [ Full content available at: https://github.com/apache/flink/pull/6646 ] This message was relayed via gitbox.apache.org for [email protected]
