`custom_metric` is serialized and sent to the client and then used to determine 
how to cluster the incoming data. Without this change, we get `[]` when using 
the default point count for aggregation and `true` when using a particular 
column (e.g. population). The client code is more readable when we send a 
proper boolean as `custom_metric`. I would probably rename this field to 
`has_custom_metric` to reflect its type.

Perhaps I should use `not label_col` here to produce a boolean for the client 
to consume?

[ Full content available at: 
https://github.com/apache/incubator-superset/pull/5902 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to