It's ok to merge. My preference would be to wait a day and then I'll split the fix into it's own PR (to make it easy to revert/bisect/cherry pick into release branches).
On Mon, Sep 17, 2018, 9:15 AM Marco de Abreu <[email protected]> wrote: > @KellenSunderland <https://github.com/KellenSunderland> it seems like > everything is passing. Is this good to merge? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/12550#issuecomment-422010803>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AHGTEyBTgpAFs9lltPM-0C9Fd87WN0ibks5ub6CJgaJpZM4WnbJC> > . > [ Full content available at: https://github.com/apache/incubator-mxnet/pull/12550 ] This message was relayed via gitbox.apache.org for [email protected]
