@leventov that is reasonable -- in that case please make it clear in your review comment that it is a mere suggestion. Otherwise a comment like "Better to use Comparator.naturalOrder()." could be interpreted as a required change.
BTW, we have Comparators.naturalNullsFirst() in Druid, which is my preference when you want it to work on nulls and you want those to go first. It is a singleton. (I know you know that, @leventov, since you added it. I'm mentioning it for Alexander's benefit if he chooses to use it.) [ Full content available at: https://github.com/apache/incubator-druid/pull/5712 ] This message was relayed via gitbox.apache.org for [email protected]
