I double check this, too. If we don't call `restorer.restoreStarted();` we don't call it all. However, if we call it here, it's incorrect, too, because within `task.reinitializeStateStoresForPartitions()` we create a restorer object.
Frankly, I am not 100% sure what the difference between `trunk` and `1.0` is -- we have changed some logic such that in this branch, after re-initializing, we never enter this method again, and thus, the call to `restorer.restoreStarted();` in line 166/168 is never triggered (ie, we need to make the call here). In `trunk` however, `startRestoration` is called once again and thus we don't need to call `restorer.restoreStarted();` after task.reinitializeStateStoresForPartitions()`. Thoughts? [ Full content available at: https://github.com/apache/kafka/pull/5657 ] This message was relayed via gitbox.apache.org for [email protected]
