Thanks Anton. I'll give it a shot. On Mon, Sep 17, 2018, 4:41 AM Anton Chernov <[email protected]> wrote:
> *@lebeg* approved this pull request. > ------------------------------ > > In ci/docker/install/ubuntu_gcc8.sh > <https://github.com/apache/incubator-mxnet/pull/12370#discussion_r217985488> > : > > > +# regarding copyright ownership. The ASF licenses this file > +# to you under the Apache License, Version 2.0 (the > +# "License"); you may not use this file except in compliance > +# with the License. You may obtain a copy of the License at > +# > +# http://www.apache.org/licenses/LICENSE-2.0 > +# > +# Unless required by applicable law or agreed to in writing, > +# software distributed under the License is distributed on an > +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > +# KIND, either express or implied. See the License for the > +# specific language governing permissions and limitations > +# under the License. > + > +sudo add-apt-repository ppa:jonathonf/gcc-8.0 > +sudo add-apt-repository ppa:jonathonf/gcc-7.3 > > Why 7.3 is also needed? > ------------------------------ > > In ci/docker/runtime_functions.sh > <https://github.com/apache/incubator-mxnet/pull/12370#discussion_r217986017> > : > > > @@ -336,6 +336,35 @@ build_ubuntu_cpu_cmake_debug() { > popd > } > > +build_ubuntu_cpu_cmake_asan() { > + set -ex > + > + pushd . > + cd /work/build > + export CC="gcc-8" > > Maybe add cmake arguments -DCMAKE_CXX_COMPILER=/usr/bin/g++-8 > -DCMAKE_CC_COMPILER=/usr/bin/gcc-8 instead? It would be more cmake'ish. > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/12370#pullrequestreview-155823187>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AHGTE7WHRyDc8YX_y7lfLYmbYKX7UISnks5ub2BBgaJpZM4WNWgi> > . > [ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ] This message was relayed via gitbox.apache.org for [email protected]
