> > Can you clarify?--I'm not sure how we can do this DirectRunner-specific > > logic elsewhere (see another place this is done on line 747). > > I meant that we should check for key-ness and deterministic coders during > pipeline construction. > > > Do we know that sliding windows were already exploded? Perhaps we should be > > setting self.has_windowed_inputs and relying on the window assignment from > > above. > > Ah oops I missed what you mean. I set the attribute per your suggestion. > > In that case, we shouldn't be re-assigning window (though perhaps worth a > comment).
Thanks, I incorporated your suggestions. PTAL. [ Full content available at: https://github.com/apache/beam/pull/6304 ] This message was relayed via gitbox.apache.org for [email protected]
