@azagrebin Yes. Just now I am reviewing my changes, and come into the situation as you think.
This PR originally comes from a discussion #6678 but @tillrohrmann undo the touch on `ActorUtils` before really merged finally( I find it just now ). Now we introduce Flink abstraction of Rpc service/Actor so that this code is stale and would remove in the near future( ideally ), right? If so, here remains a little questions that might guide the following work to achieve that. 1. The clean up of `FlinkUntypedActorTest.java` could go ahead, it is separated. This isn't legacy code IMO. 2. After a check I find, well, tests like `ResourceManagerITCase.java`, `ClusterShutdownITCase.java` and `ClientConnectionTest.java` are all legacy. They are hard to distinguish then. What is the plan we move legacy code? If it is one of milestones Flink 1.7, we can go ahead to remove them now. There should be a version we say legacy mode doesn't support any more and the breaking clean up could kick out. Currently we say the legacy codes are stale, not under maintain and would remove, but no annotations or the clean up works on going. ( anyway, I think it is quite noisy when touch legacy code but could not regard them ASAP ) [ Full content available at: https://github.com/apache/flink/pull/6701 ] This message was relayed via gitbox.apache.org for [email protected]
