I'll take another look, thanks. For future reviews In general I would suggest you to address review comments in a separate commit instead of amending and force-pushing. A separate commit makes it easier to see the changes in the PR and when a committer merges the PR, they will squash the whole PR into a single commit anyway.
It is also recommended to not auto-format whole files, because the resulting whitespace changes add clutter to the PR diff and the git blame history and more importantly can lead to conflicts in the future when cherry-picking, backporting or merging in general. Fortunately in this PR this has only happened to a few comment lines, so it's not a problem here, but for more substantial unrelated whitespace changes we usually ask the author to revert affected lines, which is a lot more work than not changing them in the first place. [ Full content available at: https://github.com/apache/parquet-mr/pull/518 ] This message was relayed via gitbox.apache.org for [email protected]
