Well, first off, I'm not an "author", just a contributor like you.
I think that you have make a good practical argument for both the function instead of supplier and the tuple instead of KeyValue. In fact, my main concern was to ensure a smooth transition from the java API to the scala one, but I'm now realizing that my exact suggestion to use implicits works the opposite direction as well... If I currently have a bunch of TransformSuppliers and don't want to turn them all into functions, I can define an implicit conversion to do it for me. And you are certainly right that the overwhelming majority of the API is already in this format, so it's smoother to just make that 100% by changing one method than by changing all the rest. So, after this discussion, I would support your suggested change. It requires a KIP, and just FYI, the deadline to get the KIP accepted for 2.1 is next Monday, which means you basically have to draft it, have a (hopefully brief) discussion, and start the vote tomorrow. This might be a stretch, but there's always 2.2. Let me know if you need any guidance. Thanks again, -John [ Full content available at: https://github.com/apache/kafka/pull/5619 ] This message was relayed via gitbox.apache.org for [email protected]
