+1 to this being a good change, and I like henning's suggestion.
I agree that we should also include the type signature of the failing function 
since it'll help narrow down where something went wrong if the stack trace gets 
swallowed.

%v and passing in c.Type() will accomplish that.

Maybe:

panic(fmt.Sprintf("incompatible func type: %v has %d %d inputs and %d outputs, 
" +    " want function of {{$in}} inputs & {{$out}} outputs", c.Type(), 
c.Type().NumIn(), c.Type().NumOut()))

[ Full content available at: https://github.com/apache/beam/pull/6156 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to