I would prefer to avoid using static methods. How about this: 1. rename class to DataflowPTransformMatchersProvider 2. Rename combineValuesTranslation to get(boolean isFnApiEnabled) 3. in DataflowRunner create instance of this class, or better utilize dependency injection and pass it to DataflowRunner constructor at [DataflowRunner.java#L330](https://github.com/apache/beam/blob/0ba9168cf087df14e635fbf360f6615863e6ea2c/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java#L330)
It is better to do first two steps anyway. 3rd step is good for future code testability and cleaner communication of dependencies. [ Full content available at: https://github.com/apache/beam/pull/6384 ] This message was relayed via gitbox.apache.org for [email protected]
