Did you mean `read < 0`? Otherwise this will spin in infinite loop when it 
encounters EOF.
Also, what should we do when read returns 0? It think the correct thing to do 
is to continue to read (unless there some expectation that that underlying 
channel should never return zero). Most blocking channels don't return zero, 
they just wait till EOF or data arrives. Better to be explicit here about the 
policy.

[ Full content available at: https://github.com/apache/beam/pull/6440 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to