[GitHub] [incubator-superset] xtinec commented on issue #5934: Ensure npm run build is in production mode

[GitHub]

@kristw I was thinking something like this in `webpack.config.js`. I'm not 100% 
sure if it would work, 
[this](https://github.com/webpack/webpack/issues/6460#issuecomment-364286147) 
seems to suggest it may. Figured it may be worth a try. 😄  
```
module.exports = (env, argv) => ({
        ...etc,
        plugins: [
           ...etc,
           new webpack.DefinePlugin({
             'process.env.WEBPACK_MODE': JSON.stringify(mode),
             'process.env.NODE_ENV': argv.mode
           })]
});
```
If not, totally cool with leaving as-is. :shipit:  👍  

[ Full content available at: 
https://github.com/apache/incubator-superset/pull/5934 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org