I think my understanding of systemTopicList is incorrect. Firstly, I thought 
that getSystemTopicList means getting all the topic names, then I read the code 
carefully yesterday and found 
[RouteInfoManager.getAllTopicList()](https://github.com/apache/rocketmq/blob/a220364b752669c474f9795884faed9bb4e0a8c1/namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java#L86)
 has done this. I traced the call chain of getSystemToplicList and found 
[MQClientAPIImpl.getSystemTopicList()](https://github.com/apache/rocketmq/blob/a220364b752669c474f9795884faed9bb4e0a8c1/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java#L1600)
 is the last method called, so RouteManagerInfo.getSystemTopicList() never be 
called? ? ? 
At the same time, I found some systemTopic will be added in 
[rocketmq.broker.topic.TopicConfigManager#TopicConfigManager()](https://github.com/apache/rocketmq/blob/a220364b752669c474f9795884faed9bb4e0a8c1/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java#L57)
 when the BrokerController is initialized, including the brokerName and cluster 
name. So the cluster name and broker name should be added to the 
systemTopicList. I am sorry, I will read the code more carefully.

[ Full content available at: https://github.com/apache/rocketmq/pull/466 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to