> @lepolac couple of compilation errors are coming. You can run `./gradlew > clean :clients:test` > to compile and test the changes. > > ``` > /Users/mkumar/workspace/kafka/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:401: > error: constructor RecordAccumulator in class RecordAccumulator cannot be > applied to given types; > this.accumulator = new RecordAccumulator(logContext, > ^ > required: > LogContext,int,CompressionType,long,long,long,Metrics,String,Time,ApiVersions,TransactionManager,BufferPool > found: > LogContext,Integer,long,CompressionType,Integer,long,int,Metrics,String,Time,ApiVersions,TransactionManager,BufferPool > reason: actual and formal argument lists differ in length > > /Users/mkumar/workspace/kafka/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:414: > error: method parseAndValidateAddresses in class ClientUtils cannot be > applied to given types; > List<InetSocketAddress> addresses = > ClientUtils.parseAndValidateAddresses(config.getList(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG)); > ^ > required: List<String>,String > found: List<String> > reason: actual and formal argument lists differ in length > ```
This should be fixed. Thanks @adammilnesmith for helping getting this in order. A few SASL authenticator related tests are failing but I believe this is unrelated to this change as none of those tests are hitting the ClientUtils class. However, I am now wondering about inter broker communication and protocol, for example do replica fetcher threads use SASL/SSL authentication, and could this change have an impact there ? [ Full content available at: https://github.com/apache/kafka/pull/4485 ] This message was relayed via gitbox.apache.org for [email protected]
