…yCheckpointComplete ## What is the purpose of the change The precondition `checkState(pendingTransactionIterator.hasNext(), "checkpoint completed, but no transaction pending");` in `TwoPhaseCommitSinkFunction.notifyCheckpointComplete()` seems to strict, because checkpoints can overtake checkpoints and will fail the precondition. In this case the commit was already performed by the first notification and subsumes the late checkpoint. I think the check can be removed.
## Brief change log Removed the precondition without replacements and created a test case for ou-of-order notification. ## Verifying this change `TwoPhaseCommitSinkFunctionTest#testSubsumedNotificationOfPreviousCheckpoint` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) [ Full content available at: https://github.com/apache/flink/pull/6723 ] This message was relayed via gitbox.apache.org for [email protected]
