I haven't had a chance to review the entire thing yet, beyond the partial review I did in https://github.com/apache/incubator-druid/pull/5957#pullrequestreview-142270140. Please don't consider me as blocking this PR, just not yet having the opportunity to review it in full.
By way of explanation as to why: I can't speak for everyone, but personally I am prioritizing my time towards reviewing PRs that make functional changes (which we are getting a lot of!) vs. ones that are refactorings/cleanups. Doesn't mean I'll never get to it, but hopefully that explains why I haven't yet. I understand this is a dev blocker for you, so I guess all I can say to that is, I would suggest avoiding making functional changes dependent on large nonfunctional ones. [ Full content available at: https://github.com/apache/incubator-druid/pull/5957 ] This message was relayed via gitbox.apache.org for [email protected]
