@villebro thank you for your review and the comments.

@mistercrunch had signed off the on code and asked other reviewers to chime in. 
When you started reviewing, I thought that you were one of the main committers 
and was addressing the comments with the hope that your sign-off would get me a 
merge commit. I was happy and excited. I fought hard within my organization to 
avoid forking the project (to maintain the alembic tree etc.) and now I lost 
the team to Looker. I wanted to work in the spirit of OpenSource.

I have been maintaining this branch for almost three months now without an end 
in sight. I am open to code reviews and changes as necessary, but most of the 
core code has remained the same without major comments. My branch is behind a 
feature flag which is disabled by default. If it was not for alembic, I would 
have used my branch in production within Affirm. I am at a loss on the next 
steps. I am even open to a rejection. I am just feeling very disappointed that 
my work has gone to waste, that too on a very important feature which the 
community has been asking for a long time.

I really don't know what to do. The [contributors 
guide](https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md)
 does not mention any guidelines on which reviewers should I ping or the steps 
needed to get a PR merged.

[ Full content available at: 
https://github.com/apache/incubator-superset/pull/5294 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to