@mahendra I'm sorry for the confusion that my involvement has caused. I initially stated that I would be happy to put in work to maintain the feature after being merged into the main codebase, and put forth comments that I thought were valid from a maintenance viewpoint. Later @mmuru asked me to perform a more thorough code review, which I did. My intention was not to derail the review process, and I am sorry if I have done so.
My only remaining comments have to do with user experience of the feature, and as such should not be seen as blockers for merging. The way I see it now that the remaining test errors have been fixed this should be good to go, and I would be happy to deploy this for gradual production use at my organisation. [ Full content available at: https://github.com/apache/incubator-superset/pull/5294 ] This message was relayed via gitbox.apache.org for [email protected]
