The three methods `createRestClientSSLContext`, `createRestServerSSLContext` 
and `createRestAuthenticationSSLContext` seem to share a lot of common code. I 
would suggest to refactor them. E.g. one could have a 
```
internalCreateRestSSLContext(configurationMode) {
    if (configurationMode & server) {
        keystore
    } else {
        null
    }

    if (configurationMode & client) {
         truststore
    } else {
         null
    }
}
```

with `ConfigurationMode = {clientSide = 1, serverSide = 2, mutual = clientSide 
| serverSide}`.

[ Full content available at: https://github.com/apache/flink/pull/6727 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to