Thanks @paroda for finding and fixing this bug. Looks good, just a couple small tweaks
- Could you please move the `coerce-map->tuple-seq` function out to the https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/src/org/apache/clojure_mxnet/util.clj namespace? This way it can be reused by other functions that might need that conversion. - Please add a test for the conversion so that it help document it for others in https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/test/org/apache/clojure_mxnet/util_test.clj and then a quick test to exercise the forward with those extra args in https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/test/org/apache/clojure_mxnet/executor_test.clj Thanks again for you help. It is much appreciated 😸 [ Full content available at: https://github.com/apache/incubator-mxnet/pull/12630 ] This message was relayed via gitbox.apache.org for [email protected]
