This change does fix it for all tests that use the MockProcessorContext.

I'm happy to remove this change from this PR and do a separate one, if you're 
not happy with the current state of it. I wouldn't want to mess with extracting 
it and bloating the current PR even more than it currently is. 

I think it's better not to log the config for unit tests. I disabled it because 
the extra logging made it hard for me to read the unit test output.

Logging the config is really only useful during runtime so we know what 
configurations people are running when they post logs to the mailing list. When 
a test fails, you can easily just look at the test's configuration.

Bill brought this up earlier. I can make a non-logging config for sharing 
between MockProcessorContext and the TopologyTestDriver. I'm hesitant to share 
the config class between the test utils and production code, as the risk of 
making an apparently harmless change in one context and screwing up the other 
is non-trivial.

Let me know if you want me to remove this from this PR now, or I can also just 
create a Jira to make a class for the test-utils to share.

[ Full content available at: https://github.com/apache/kafka/pull/5567 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to