@chamikaramj - thanks and I agree. This PR provides what folk have 
outlined/requested, does not change the `FileSystem` API and I believe gets us 
as close to allowing a `FileSystems.rename()` within a loop as is possible. 
Some `FileSystem` implementations will currently always overwrite but we can 
document that scenario or opt to open tickets to change to throw 
`FileAlreadyExistsException` if we so wish. 

I will provide tests for this unless someone has objection with the 
implementation offered. I haven't yet seen anything specific but all comments 
have helped in my understanding of the background (thank you!). If we want to 
redesign things further we can discuss that on dev@. 

@chamikaramj - would you be willing to be reviewer please? 


[ Full content available at: https://github.com/apache/beam/pull/6289 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to