It’s now showing up as a Pull request, is there anything else to do? > On Sep 22, 2018, at 10:44 AM, Jan Piotrowski <[email protected]> wrote: > > Common misunderstanding: You are creating the pull requests from the branch > in your fork to master in your fork. They show up here: > https://github.com/sdgpalm2/cordova-plugin-splashscreen/pulls > <https://github.com/sdgpalm2/cordova-plugin-splashscreen/pulls> You have to > create the Pull Request to this repository, for example by creating the PR > here: https://github.com/apache/cordova-plugin-splashscreen/compare > <https://github.com/apache/cordova-plugin-splashscreen/compare> > As I saw your two PRs, I noticed you edited the files in two different > branches - sdgpalm2-patch-1 and sdgpalm2-patch-2 - which means you also need > two PRs to get all the changes in. This should not be the case, you should > try to edit both files in the same branch. You can do that by either going to > one of the branches in your repository and also edit the other file, or > create a Pull Request from one branch to the other, merge it and then merge > that branch into the Cordova repository. > > Let me know if this works. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-423761145>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/Apejd_QaTcdlUvQfWFyAcDONmPpBcvqkks5udnbqgaJpZM4W1Lu1>. >
[ Full content available at: https://github.com/apache/cordova-plugin-splashscreen/issues/158 ] This message was relayed via gitbox.apache.org for [email protected]
