I was able to narrow down this error to `uglifyjs-webpack-plugin@2`. In the 
[release notes  for 
2.0.0](https://github.com/webpack-contrib/uglifyjs-webpack-plugin/releases/tag/v2.0.0)
 they note:
> Switch back to uglify-js (uglify-es is abandoned, if you need uglify ES6 code 
> please use terser-webpack-plugin).

I tested it out and it looks like `terser-webpack-plugin` should work as a 
drop-in replacement, see https://github.com/theneuralbit/arrow/tree/dom/ts3

We should probably make sure this doesn't significantly change the size of our 
UMD builds or anything like that. Also I'm not sure if [the safari 10 
workaround](https://github.com/TheNeuralBit/arrow/blob/dom/ts3/js/gulp/minify-task.js#L86)
 is still working. Could someone with a mac test out es2015/umd?

EDIT:
I checked on the build sizes, and it looks like everything is actually slightly 
smaller with terser (and the updated closure compiler for es5):

With uglify:
-rw-r--r-- 1 hulettbh hulettbh 117215 Sep 23 16:21 targets/es2015/umd/Arrow.js
-rw-r--r-- 1 hulettbh hulettbh 131668 Sep 23 16:21 targets/es5/umd/Arrow.js
-rw-r--r-- 1 hulettbh hulettbh 117215 Sep 23 16:21 targets/esnext/umd/Arrow.js

With terser:
-rw-r--r-- 1 hulettbh hulettbh 116989 Sep 23 16:28 targets/es2015/umd/Arrow.js
-rw-r--r-- 1 hulettbh hulettbh 128568 Sep 23 16:28 targets/es5/umd/Arrow.js
-rw-r--r-- 1 hulettbh hulettbh 116989 Sep 23 16:28 targets/esnext/umd/Arrow.js


[ Full content available at: https://github.com/apache/arrow/pull/2611 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to