Oh, I didn't go to see the related implementation of `ElasticsearchSink `. This 
is just a suggestion, because when I first saw the name, I thought it was an 
empty method, didn't do anything because you called it "NoOp", and in fact you 
throw an exception, it will cause the sink task to fail if the outer layer does 
not handle it. Maybe you can listen to other people's opinions and see if it is 
a better choice to keep up with the implementation of `ElasticsearchSink `.

[ Full content available at: https://github.com/apache/flink/pull/6732 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to