It seems that the goal of `standard_library.install_aliases()` call is to forward-port 14 modules listed in: http://python-future.org/standard_library_imports.html -> Aliased imports, which in general seems to be reasonable for Python 3 compatibility.
Among affected modules/functions, I have only found several usages of `urllib.*` and `zip_longest` in Beam, all of which are imported from `future.*`, which makes `install_aliases()` call indeed redundant. Except for one file: `runners/interactive/cache_manager.py` - we should probably fix that in https://github.com/apache/beam/pull/6451. https://github.com/apache/beam/blob/02eadb12d583b876f639aee027dc61f8c18191df/sdks/python/apache_beam/runners/interactive/cache_manager.py#L26 Shouldn't `py27-lint3` have caught and complained about `cache_manager.py`? Also since `install_aliases` seems to change behavior on Python 2, did you an observe any incorrect behavior on Python 2? Should we be worried and cherry-pick this change into an upcoming release? Hopefully not. [ Full content available at: https://github.com/apache/beam/pull/6471 ] This message was relayed via gitbox.apache.org for [email protected]
