I pushed a new solution to delaying shutting down in the face of a non-error GOAWAY. The original solution was causing another crash (as noted by the linked PR).
This solution doesn't set any fini event. It it instead just tracks the last stream id specified by the GOAWAY frame. This effectively will disable push from ATS back to the client. In all other ways, the processing of streams initiated by the client will continue. In the 99% case when the client really meant to shutdown, an EOS on the connection will quickly follow and that will cause the FINI event to be processed. I also added a metric to track the number of streams that are finished after the client sends a GOAWAY. In our environment this is a small but not non-zero value. @maskit could you take another look? [ Full content available at: https://github.com/apache/trafficserver/pull/4097 ] This message was relayed via gitbox.apache.org for [email protected]
