This validation doesn't actually check that it's non-negative. I'm not sure that we want to, though. Also, I'd use `Objects.toString()` on `name` just in case it's null. Finally, it might be nice to wrap the substituted variables with brackets to make the result more readable. All together, this would yield: * `"[" + Objects.toString(name) + "] shouldn't be null.", e);` * `"[" + Objects.toString(name) + "] is too big to be converted to milliseconds: [" + d + "]", e);`
What do you think about this? (also below) [ Full content available at: https://github.com/apache/kafka/pull/5682 ] This message was relayed via gitbox.apache.org for [email protected]
