I checked the select method again, it can not make sure return a new invoker, 
check this method: 
org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker#reselect, use 
invokers not in `selected` first, if all invokers are in `selected`, just pick 
an available one using loadbalance policy.

So in order to make sure the `selected` are different, the if statement is 
required.

With the context of 
org.apache.dubbo.rpc.cluster.support.ForkingClusterInvoker#doInvoke, IMO, it 
won't get less forks, and the if statement improves code robustness.

[ Full content available at: 
https://github.com/apache/incubator-dubbo/issues/2547 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to