This is fine for non blocking. For blocking did you consider a second message (resource release in addition to active ack)?
-r > On Sep 25, 2018, at 4:29 AM, Christian Bickel <[email protected]> > wrote: > > Until now, an active-ack is sent before logs of a container are collected. If > one customer writes a lot of logs or if log-collection is slow for some other > reason, the invoker already gets new activations, that are queueing up. > This PR changes the behavior, to send the active-ack (for non-blocking) > activations after log collection is finished. For blocking actions, there are > two active acks now. One with the response for the user and one to free up > the space in the bookkeeping of the loadbalancer. > > I've put this proposal on the dev-list for discussion: > https://lists.apache.org/thread.html/726c802f38f3872d057f9adb6a52043eeb8fbd68b601c57bdb12d706@%3Cdev.openwhisk.apache.org%3E > > Related issue and scope > > I opened an issue to propose and discuss this change (#????) > My changes affect the following components > > API > Controller > Message Bus (e.g., Kafka) > Loadbalancer > Invoker > Intrinsic actions (e.g., sequences, conductors) > Data stores (e.g., CouchDB) > Tests > Deployment > CLI > General tooling > Documentation > Types of changes > > Bug fix (generally a non-breaking change which closes an issue). > Enhancement or new feature (adds new functionality). > Breaking change (a bug fix or enhancement which changes existing behavior). > Checklist: > > I signed an Apache CLA. > I reviewed the style guides and followed the recommendations (Travis CI will > check :). > I added tests to cover my changes. > My changes require further changes to the documentation. > I updated the documentation where necessary. > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/incubator-openwhisk/pull/4041 > > Commit Summary > > Send active-ack after log collection for nonblocking activations. > File Changes > > M common/scala/src/main/scala/whisk/core/connector/Message.scala (5) > M > core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala > (83) > M core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala > (22) > M core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala (9) > M > tests/src/test/scala/whisk/core/containerpool/test/ContainerProxyTests.scala > (2) > Patch Links: > > https://github.com/apache/incubator-openwhisk/pull/4041.patch > https://github.com/apache/incubator-openwhisk/pull/4041.diff > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or mute the thread. [ Full content available at: https://github.com/apache/incubator-openwhisk/pull/4041 ] This message was relayed via gitbox.apache.org for [email protected]
