I tested stubbing Superset's `slugify` implementation with `kebabCase` from `lodash` and it passes all test cases under this `it` except one.
`kebabCase`: `"camelCase"` => `"camel-case"` `slugify`: `"camelCase"` => `"camelcase"` This was the only difference. IMO, I am leaning towards switching to `lodash`'s `kebabCase` which is well-tested library and industry standard than custom implementation and then remove `slugify` from codebase. I checked where the function `slugify` is being used and it is used for creating tooltip `id` string. My understanding is this is harmless change, so I made the move for it. Please correct me if I misunderstood. [ Full content available at: https://github.com/apache/incubator-superset/pull/5946 ] This message was relayed via gitbox.apache.org for [email protected]
