diecui1202 commented on a change in pull request #2527: #2489 fixed consumer
mock=force not effected
URL: https://github.com/apache/incubator-dubbo/pull/2527#discussion_r220440129
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConfigUtils.java
##########
@@ -57,8 +57,9 @@ public static boolean isEmpty(String value) {
}
public static boolean isDefault(String value) {
- return "true".equalsIgnoreCase(value)
- || "default".equalsIgnoreCase(value);
+ return (value != null) && ("true".equalsIgnoreCase(value)
+ || "force".equalsIgnoreCase(value)
Review comment:
It's not suitable for adding 'force' as default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
