carryxyh commented on a change in pull request #2562: Update ConfigUtils.java
URL: https://github.com/apache/incubator-dubbo/pull/2562#discussion_r220449753
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConfigUtils.java
##########
@@ -217,7 +217,8 @@ public static Properties loadProperties(String fileName,
boolean allowMultiFile)
*/
public static Properties loadProperties(String fileName, boolean
allowMultiFile, boolean optional) {
Properties properties = new Properties();
- if (fileName.startsWith("/")) {
+ //add scene judgement in windows environment Fix 2557
+ if (fileName.startsWith("/")||fileName.matches("^[A-z]:\\\\\\S+$")) {
Review comment:
1. Would u pls format your code?
2. Pls use doc as this:
// add scene...
Remember the space.
3. pls add some unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
