I agree with not writing selector string multiple times. More thinking about where to put the function. My main concern is avoiding a setup that leads to one exploding file that contains selectors from every part of Superset. From the name of the file now it invites people to add selector from all other pages here. Other options would be - Rename this to `sqlLab.js` to scope it a bit. - Put the function in test file itself.
I am more comfortable with either option above. [ Full content available at: https://github.com/apache/incubator-superset/pull/5974 ] This message was relayed via gitbox.apache.org for [email protected]
