The separation between `setUserCodeClassLoader(userCodeClassLoader);` and `read(in)` seems a bit unclean, the methods always require to be used in conjunction. It also leads a field "classloader" in the snapshot which is sometimes set and sometimes not.
That is typically an indication that this should be one method: `read(in, classloader)`. That does not match the `IOReadableWritable` interface, but I see not why the config snapshots need to have that specific interface. They could simply define their own interface. If this blows the scope of this change, I would suggest to plan a followup to clean this up. [ Full content available at: https://github.com/apache/flink/pull/6711 ] This message was relayed via gitbox.apache.org for [email protected]
