Make sure you have checked _all_ steps below.

### Jira

- [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW-3124) issues and references 
them in the PR title.
### Description

- [x] Here are some details about my PR, including screenshots of any UI 
changes:
The command `airflow webserver -d` crashes when `settings.RBAC == True`. This 
is because `create_app` currently returns `app, appbuilder`, which causes the 
app to crash with an `AttributeError`. Reading through the code, it doesn't 
look like we rely on `appbuilder` being returned by `create_app` anywhere, so 
it should be safe to remove this. 

### Tests

- [x] My PR adds the following unit tests

I set up the CLI to pass in the `unit_test_mode` setting to the flask app so we 
can disable the werkzeug reloader when running tests. If the reloader runs, 
there is an extra monitoring process left running after killing the main 
webserver process. This causes conflicts if multiple tests rely on being able 
to start a webserver (as the process will not be able to bind to the default 
socket).

### Commits

- [x] My commits all reference Jira issues in their subject lines, and I have 
squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
  1. Subject is separated from body by a blank line
  1. Subject is limited to 50 characters (not including Jira issue reference)
  1. Subject does not end with a period
  1. Subject uses the imperative mood ("add", not "adding")
  1. Body wraps at 72 characters
  1. Body explains "what" and "why", not "how"


### Code Quality

- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`


[ Full content available at: 
https://github.com/apache/incubator-airflow/pull/3958 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to