@TheNeuralBit you're right that we `subarray` the valueOffsets buffer when we slice, but we still need to call `getZeroBasedValueOffsets()` in all these places because it also does work in the case that [`valueOffsets[0] != 0`](https://github.com/apache/arrow/blob/bcd58caa59d26f6c15d4eb9f7ded758d4227f10f/js/src/ipc/writer/binary.ts#L324). That will be true if we performed any meaningful `valueOffsets.subarray()` slice in the data's `sliceInternal()` method, in which case we need to adjust all the values in the valueOffsets Array on the way out.
[ Full content available at: https://github.com/apache/arrow/pull/2638 ] This message was relayed via gitbox.apache.org for [email protected]
