The fact that these issues were found only after moving tests from `src/test/java/` to `src/main/java/` indicates that checkstyle probably isn't checking for issues in our tests in other modules either. I think it should. I found at least one bug (failure to confirm that an expected exception was thrown) going through these and triaging them, and another one that could have easily become a bug (reuse of an existing TestTransaction variable). Running checkstyle to help triage potential issues in tests is just as important for ensuring our tests are high quality, as it is to ensure our main code is high quality.
[ Full content available at: https://github.com/apache/fluo/pull/1050 ] This message was relayed via gitbox.apache.org for [email protected]
