Yeah, I don't like the verbosity either. But IMO that's a much lesser evil than a runtime error.
>Would you still reject the PR for this? Ehh, I'd really rather see it compile-time. A compile-time error is 1000x better than a test (tangentially, the same goes for normalized data, making data bugs impossible). Tests are always imperfect, it's usually impossible to test all possible combinations, and they only test the expectations of the person writing them in that moment. All it takes is for someone to forget or a reviewer to not notice it once. Whereas the compile error guarantees the bug is impossible. [ Full content available at: https://github.com/apache/trafficcontrol/pull/2886 ] This message was relayed via gitbox.apache.org for [email protected]
