This is a sub task of ARROW-3089.  The scope of this builder is just for types 
that implement the `ArrowPrimitiveType` trait, i.e. `PrimitiveArray`'s.

There are a number of follow up items that need to be addressed below.  I will 
create JIRA's for these once/if this PR is accepted.  I wanted to ensure that 
others agree with the approach and get some feedback.

Follow up items (JIRA's to be created upon merging this PR):
 - support for `Option<T> where T: ArrowPrimitiveType`
 - add padding up to 64 bytes, `From<Vec<T>>` does not do this at the moment 
and I am testing against it
 - expand the `add_primitive_array_impl` macro to `u8` and `i8` (this 
frustrated me no end...)
 - expand capacity and copy over array when capacity is reached?

cc @kszucs @sunchao @andygrove 

[ Full content available at: https://github.com/apache/arrow/pull/2648 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to