I am not sure if we need to add this unit-test. As far as I understood the specs, if we are [using temporary security credentials](https://docs.aws.amazon.com/AmazonS3/latest/dev/RESTAuthentication.html#UsingTemporarySecurityCredentials) then the signature calculations also require the temporary security token header to be included ([v4](https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-authenticating-requests.html)) but the token is not directly related to S3 auth v4 signing functionality (algorithm) which is unit-tested here.
Adding the temporary security credentials token header does not change the functionality of the S3 auth v4 signing in any way (only the result of a particular signature calculation because an extra arbitrary header is added). This is already tested with `HeaderA` ... `HeaderF` in the existing unit test. It seems to me we would need to test the addition of the corresponding `amz-security-token` header in the plugin which this unit-test-bench does not test (it tests the v4 signing utility and not the plugin as a whole) I hope it makes sense. [ Full content available at: https://github.com/apache/trafficserver/pull/4302 ] This message was relayed via gitbox.apache.org for [email protected]
