codecov-io edited a comment on issue #2343: Enhance TagRouter: modify tag router strategy URL: https://github.com/apache/incubator-dubbo/pull/2343#issuecomment-415638443 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=h1) Report > Merging [#2343](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/be51a115dee9935b96e69d35c75ee158a63fd807?src=pr&el=desc) will **increase** coverage by `0.05%`. > The diff coverage is `90%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2343 +/- ## ============================================ + Coverage 55% 55.06% +0.05% - Complexity 5283 5288 +5 ============================================ Files 573 573 Lines 25538 25537 -1 Branches 4531 4531 ============================================ + Hits 14047 14061 +14 + Misses 9381 9369 -12 + Partials 2110 2107 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...dubbo/rpc/cluster/router/tag/TagRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXJGYWN0b3J5LmphdmE=) | `100% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: | | [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `70.58% <90%> (+4.87%)` | `12 <0> (+1)` | :arrow_up: | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `54.11% <0%> (-2.36%)` | `21% <0%> (ø)` | | | [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `59.16% <0%> (+0.83%)` | `31% <0%> (+1%)` | :arrow_up: | | [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=) | `78.67% <0%> (+1.47%)` | `29% <0%> (ø)` | :arrow_down: | | [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `83.33% <0%> (+5.55%)` | `6% <0%> (+1%)` | :arrow_up: | | [...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0Z1dHVyZUFkYXB0ZXIuamF2YQ==) | `64.51% <0%> (+6.45%)` | `3% <0%> (ø)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `66.25% <0%> (+8.75%)` | `21% <0%> (+2%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=footer). Last update [be51a11...5cefca2](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
