carryxyh commented on a change in pull request #2445: [Dubbo-2328]Fix the
concurrency limit of 'ActiveLimitFilter' to calculate atomicity
URL: https://github.com/apache/incubator-dubbo/pull/2445#discussion_r221193569
##########
File path:
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/RpcStatus.java
##########
@@ -334,4 +340,28 @@ public Semaphore getSemaphore(int maxThreadNum) {
return executesLimit;
}
+
+
+ /**
+ * Get the semaphore for thread number. Semaphore's permits is decided by
{@link Constants#ACTIVES_KEY}
+ *
+ * @param maxThreadNum value of {@link Constants#ACTIVES_KEY}
+ * @return thread number semaphore
+ */
+ public Semaphore getActivesSemaphore(int maxThreadNum) {
+ if(maxThreadNum <= 0) {
Review comment:
format your code, pls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
