- reintroduce `xcode` as needed in 8.1.x to avoid breaking plugins such as 
`branch-cordova-sdk` before next major release, to resolve GH-706 (bug #706)
- emit a message in case someone uses `requireCordovaModule('xcode')` that it 
is now deprecated, will be removed in the near future, along with the 
recommended solution

This fix is NOT WANTED in `master` branch. I think we do not want to support 
`requireCordovaModule('xcode')` in the next major release.

This fix was tested as follows:
* pushed this change to `bug-706-xcode-hotfix-test` on my fork
* made `bug-706-xcode-hotfix-test` branch on my fork of `cordova-cli` that uses 
cordova-lib from 
`git+https://github.com/brodybits/cordova-lib.git#bug-706-xcode-hotfix-test` as 
dependency
* In <https://github.com/brodybits/cordova-xcode-error> (fork of 
<https://github.com/Tallyb/cordova-xcode-error> with `config.xml` fix):
  - I used cross-platform `nvs` tool (<https://github.com/jasongin/nvs>) to 
switch to Node.js 10.10 and do `npm i -g 
https://github.com/brodybits/cordova-cli#bug-706-xcode-hotfix-test`
  - `cordova platform add ios` outputs the deprecation message, does not fail 
with the `xcode` error

Resolves #706 

[ Full content available at: https://github.com/apache/cordova-lib/pull/708 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to