I hereby approve this PR with note of a nit that I can think of: In case a user upgrades from Cordova 8, using `requireCordovaModule` with some modules will result in the warning message while using `requireCordovaModule` with some other modules will result in an installation error. Here are the modules I can find from Cordova 8 (8.0.0) that were dropped in `master`: - `aliasify` - `dependency-ls` - `glob` - `nopt` - `opener` - `plist` - `properties-parser` - `request` - `shelljs` - `tar` - `unorm` - `valid-identifier` - `xcode`
Another minor nit is that `cordova-js` is dropped in master. I suspect this should not be an issue in practice, just something we may want to be aware of. [ Full content available at: https://github.com/apache/cordova-lib/pull/707 ] This message was relayed via gitbox.apache.org for [email protected]
